From 354073d9a2071fa58e18d471bb6bd70dd171face Mon Sep 17 00:00:00 2001 From: Daniel Rodríguez Troitiño Date: Thu, 8 Oct 2009 08:48:34 +0200 Subject: Test multipart upload with a semicolon in the name. Test a multipart upload in which the specified filename includes a semicolon. Should be parsed with the included filename, but Rack stops at the filename. Signed-off-by: Christian Neukirchen --- test/multipart/semicolon | 6 ++++++ test/spec_rack_utils.rb | 12 ++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 test/multipart/semicolon diff --git a/test/multipart/semicolon b/test/multipart/semicolon new file mode 100644 index 00000000..00fd68ab --- /dev/null +++ b/test/multipart/semicolon @@ -0,0 +1,6 @@ +--AaB03x +Content-Disposition: form-data; name="files"; filename="fi;le1.txt" +Content-Type: text/plain + +contents +--AaB03x-- \ No newline at end of file diff --git a/test/spec_rack_utils.rb b/test/spec_rack_utils.rb index c3974299..52333773 100644 --- a/test/spec_rack_utils.rb +++ b/test/spec_rack_utils.rb @@ -383,6 +383,18 @@ context "Rack::Utils::Multipart" do params["files"][:tempfile].read.should.equal "" end + specify "should parse multipart upload with filename with semicolons" do + env = Rack::MockRequest.env_for("/", multipart_fixture(:semicolon)) + params = Rack::Utils::Multipart.parse_multipart(env) + params["files"][:type].should.equal "text/plain" + params["files"][:filename].should.equal "fi;le1.txt" + params["files"][:head].should.equal "Content-Disposition: form-data; " + + "name=\"files\"; filename=\"fi;le1.txt\"\r\n" + + "Content-Type: text/plain\r\n" + params["files"][:name].should.equal "files" + params["files"][:tempfile].read.should.equal "contents" + end + specify "should not include file params if no file was selected" do env = Rack::MockRequest.env_for("/", multipart_fixture(:none)) params = Rack::Utils::Multipart.parse_multipart(env) -- cgit v1.2.3-24-ge0c7